Small refactor UnifiedPushHelper

[p1gp1g]

Type of change

• Feature
• Bugfix
• Technical
• Other : refactor

Content

Small refactor of UnifiedPushHelper : simplified and redundancies removed.

Motivation and context

As shown in #6890, before this PR (6890), the unregisterFirst parameter was only used when there was no distributor. And it is set to true only when it is removed first (registerInternal with force = true). So this parameter is useless.

Simplifying this Helper may avoid other issues like the dialog opened without the allowExternalUnifiedPushDistributors feature.

Screenshots / GIFs

Tests

• Step 1
• Step 2
• Step ...

Tested devices

• Physical
• Emulator
• OS version(s): 12

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[p1gp1g]

Merged with #7068