App layout Home screen empty states #7007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a pb with the description, this PR does not close #6999 |
bmarty
reviewed
Sep 5, 2022
vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListViewModel.kt
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListViewModel.kt
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/home/room/list/home/RoomListEmptyItem.kt
Outdated
Show resolved
Hide resolved
|
|
||
| override fun bind(holder: Holder) { | ||
| super.bind(holder) | ||
| holder.stateView.state = emptyData ?: StateView.State.Content |
There was a problem hiding this comment.
I guess in this case emptyData will never be null, so it could be a lateinit var
Agree, but problem here is that both recent carousel and filter tabs are part of the same recycler as rooms list, so we can't put whole list inside |
bmarty
approved these changes
Sep 5, 2022
ElementBot
reviewed
Sep 5, 2022
| android:id="@+id/stateView" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| android:background="?android:colorBackground"> |
There was a problem hiding this comment.
⚠️ Possible overdraw: Root element paints background?android:colorBackgroundwith a theme that also paints a background (inferred theme is@android:style/Theme.Holo)⚠️ Possible overdraw: Root element paints background?android:colorBackgroundwith a theme that also paints a background (inferred theme is@android:style/Theme.Holo)
ericdecanini
approved these changes
Sep 5, 2022
vector/src/main/java/im/vector/app/features/home/room/list/home/HomeRoomListViewModel.kt
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Content
new app layout home screen needs empty states
Motivation and context
closes #6835
Screenshots / GIFs