Fix regression on our dependency, due to merge of #6788. #7169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not use `android-embedded_fcm_distributor` anymore (since #7068). The code was compiling because `android-embedded_fcm_distributor` has a dependency on `firebase-messaging`.
bmarty
force-pushed
the
feature/bma/fix_dependencies_regression
branch
from
aca2d98 to
874bcc1
Compare
bmarty
requested review from
a team,
ouchadam and
ganfra
and removed request for
a team and
ouchadam
bmarty
added
the
Z-NextRelease
|
Kudos, SonarCloud Quality Gate passed!
|
ganfra
approved these changes
Sep 19, 2022
|
ahh great catch! this is the danger of introducing new files, there's no conflicts 😢 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not use
android-embedded_fcm_distributoranymore (since #7068). The code was compiling becauseandroid-embedded_fcm_distributorhas a dependency onfirebase-messaging.No need for a changelog, since the code is not released.