[Device management] Sign out a session (PSG-742)

[mnaturel]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

Adding a signout button in the session overview screen.

Motivation and context

Closes #7190

Screenshots / GIFs

Tests

• Enable the feature flag for new device management
• Go to Settings -> Security & Privacy -> Show all sessions (WIP, V2)
• Press a session item to go to the corresponding session overview screen
• Press the signout button
• Check reauth is asked if needed
• Check the screen is exited after signout is done
• Check the session has disappeared from the screens
• Try the same process with the current session
• Check the app is restarted in this case

Tested devices

• Physical
• Emulator
• OS version(s): Android 11

Checklist

• Changes has been tested on an Android device or Android emulator with API 21
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR
• If you have modified the screen flow, or added new screens to the application, you have updated the test UiAllScreensSanityTest.allScreensTest()

[jmartinesp]

LGTM!

[mnaturel]

To improve it, we need to add a confirmation dialog when trying to sign out another session like for the current session.

[mnaturel]

@jmartinesp I have added a confirmation dialog for all session types since it is a destructive operation. You can see it here: 082fa1e

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

74.9% Coverage
0.0% Duplication

[jmartinesp]

The last change seems to be working fine and the code makes sense. It feels a bit weird to have a SignOutUiWorker that's not shared for sign out from current session and sign out from other sessions, but it's not a blocker.

[mnaturel]

The last change seems to be working fine and the code makes sense. It feels a bit weird to have a SignOutUiWorker that's not shared for sign out from current session and sign out from other sessions, but it's not a blocker.

Yes I am also concerned about that (especially because it is not easily testable right now) but that would mean to refactor all the signout of current session process. I didn't want to start this work in this PR.