Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Timeline]: Editing a reply from iOS breaks the "in reply to" rendering (PSG-1168) #8151

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

mnaturel
Copy link
Contributor

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

When getting the last edited content for a reply, we ensure there is a formatted body so that it is still considered as a reply in the timeline.

Motivation and context

According to Matrix specification the formatted body is not mandatory so we should cover missing formatted body cases.
Closes #8150

Screenshots / GIFs

Tests

  • From iOS client, send a reply to a message
  • From iOS client, edit the reply
  • Check in Android client, the message is well rendered in the timeline

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 11

Checklist

@mnaturel mnaturel changed the title [Timeline]: Editing a reply from iOS breaks the "in reply to" rendering [Timeline]: Editing a reply from iOS breaks the "in reply to" rendering (PSG-1168) Feb 20, 2023
@mnaturel mnaturel marked this pull request as ready for review February 20, 2023 15:32
@mnaturel mnaturel requested review from a team and ganfra and removed request for a team February 20, 2023 15:32
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

19.6% 19.6% Coverage
0.0% 0.0% Duplication

Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaturel mnaturel merged commit 24e1740 into develop Feb 22, 2023
@mnaturel mnaturel deleted the fix/mna/edited-reply-parsing branch February 22, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Timeline]: Editing a reply from iOS breaks the "in reply to" rendering
2 participants