Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jump to unread marker instead of first unread message #8305

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Jump to unread marker instead of first unread message #8305

merged 2 commits into from
Apr 4, 2023

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Apr 4, 2023 •
edited
Loading

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

#8268

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested review from a team, jmartinesp and giomfo and removed request for a team April 4, 2023 08:16
jmartinesp
jmartinesp approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

giomfo
giomfo approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@yostyle yostyle marked this pull request as ready for review April 4, 2023 12:14
@yostyle yostyle enabled auto-merge (squash) April 4, 2023 12:15
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@yostyle yostyle merged commit da5a3ea into develop Apr 4, 2023
@yostyle yostyle deleted the yostyle/fix_unread_marker branch April 4, 2023 12:50
@yostyle yostyle mentioned this pull request Apr 4, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giomfo giomfo giomfo approved these changes

@jmartinesp jmartinesp jmartinesp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yostyle @jmartinesp @giomfo