Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message rendering when editing #8377

Merged
merged 2 commits into from
May 2, 2023
Merged

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Apr 28, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

#748

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@yostyle yostyle requested review from a team, bmarty, jmartinesp and giomfo and removed request for a team April 28, 2023 18:05
@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a bit broken when the rich text editor is enabled (the raw <a href="..."> stuff appears) but we probably need to upgrade it to get this properly working.

Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests ok

@yostyle yostyle enabled auto-merge (squash) May 2, 2023 12:20
@giomfo
Copy link
Member

giomfo commented May 2, 2023

LGTM. It's a bit broken when the rich text editor is enabled (the raw <a href="..."> stuff appears) but we probably need to upgrade it to get this properly working.

@jmartinesp I observed this only if "Text formatting" is disabled in the composer option. I think this is normal in this case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants