Skip to content

Move crypto migration #8666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Conversation

yostyle
Copy link
Contributor

@yostyle yostyle commented Oct 13, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Move crypto rust migration in the right place.

Motivation and context

Keys migration from kotlin to rust crypto does not work when an account has a single session and no backup.
@BillCarsonFr is aware about this problem

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Sorry, something went wrong.

@yostyle yostyle marked this pull request as ready for review October 13, 2023 15:51
@yostyle
Copy link
Contributor Author

yostyle commented Oct 23, 2023

Signed-off-by: yostyle y.pintas@gmail.com

@bmarty bmarty requested a review from BillCarsonFr November 7, 2023 13:13
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yostyle yostyle force-pushed the yostyle/fix_crypto_migration branch from 9fa2061 to 31d3b9d Compare November 16, 2023 15:45
yostyle and others added 3 commits December 15, 2023 10:36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Dec 21, 2023
@bmarty bmarty merged commit e818f86 into element-hq:develop Dec 21, 2023
@yostyle
Copy link
Contributor Author

yostyle commented Dec 21, 2023

Thanks @bmarty @BillCarsonFr

@yostyle yostyle deleted the yostyle/fix_crypto_migration branch December 21, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants