Skip to content

Fix send button blinking with RTE #8770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix send button blinking with RTE #8770

merged 1 commit into from
Mar 4, 2024
+20 −8

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Mar 4, 2024 •
edited
Loading

Add a small debounce operation in the TextWatcher so we don't process the temporary empty text triggered by the RTE.

@ganfra
Fix send button blinking with RTE

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
21d685f
@ganfra ganfra requested a review from jmartinesp March 4, 2024 09:24
jmartinesp
jmartinesp approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@ganfra ganfra merged commit b4b11a5 into develop Mar 4, 2024
@ganfra ganfra deleted the feature/fga/fix_send_button_blinking branch March 4, 2024 10:21
@giomfo giomfo mentioned this pull request Apr 12, 2024
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinesp jmartinesp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ganfra @jmartinesp