Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup secure backup #8786

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Fix setup secure backup #8786

merged 3 commits into from
Mar 21, 2024

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Mar 20, 2024

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This PR contains 2 fixes:

  • the first one (5cd78c0) ensure that the keys displayed on screen are refresh as fast as possible after a reset key. Previously the user had to wait for the next sync response to see the displayed key change in this screen:
image

To reproduce, on this screen ^ click on "Reset Keys" and observe that as soon as the loading dialog is dimissed, the keys are updated on screen. Previously user had to wait at most 30s to see the update.

  • The second fix (1155c43) ensures that when the BootstrapReAuthFragment is displayed, a first submit request is performed. Else an infinite loading wheel was displayed.

To reproduce the issue:

  • create a new account on EA by selecting matrix.org (or another HS)
  • when the account is created and the welcome screen is displayed (with action to personalize the account, and a "take me home button"), kill the app (do not go on the home screen for the moment).
  • start the application again, a dialog "Encryption upgrade available" is displayed, if you click on it, a bottom sheet is opened with an infinite loading wheel.

With this PR, the infinite loading wheel is not displayed, and if necessary, the ReAuthActivity is launch, to either ask the user to enter their password or login again using SSO

I have tested OK the direct flow (i.e. without entering the password) and the flow with entering the password. To test this flow you have to wait for the grace period server side to expire (not sure what the grace period duration is on matrix.org).

Motivation and context

Fix infinite loading wheel.

Screenshots / GIFs

Tests

  • See content above.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested review from ganfra and giomfo March 20, 2024 10:13
Copy link
Member

@giomfo giomfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@bmarty bmarty added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Mar 20, 2024
@bmarty bmarty merged commit b23757c into develop Mar 21, 2024
15 of 16 checks passed
@bmarty bmarty deleted the feature/bma/setupSecureBackup branch March 21, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants