-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reporting super properties to posthog (appPlatform) #8839
Support reporting super properties to posthog (appPlatform) #8839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some non-blocking remarks.
vector/src/main/java/im/vector/app/core/di/ActiveSessionHolder.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/analytics/impl/DefaultVectorAnalytics.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/features/analytics/impl/DefaultVectorAnalytics.kt
Show resolved
Hide resolved
… not need a session to get the value. This simplify a lot accessing this data.
|
Updated analytics events to latest version and report them properly
Type of change
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist