Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tiles be based on RTC member #2701

Open
wants to merge 99 commits into
base: livekit
Choose a base branch
from

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Oct 30, 2024

Currently a tile is shown whenever livekit has a participant.
This is wrong in a couple of situations:

  • If there are members in the livekit room that are not in the matrix room. (This can happen since we do not have any control over what the lk server is doing)
  • If a user is joined in matrix but they struggle to create a livekit connection that is a state we want to show to the user but currently we dont know about that. Since without a livekit participant we dont have any tile.
  • If someone leaves but still continue connects to livekit, we can remove their tile.
  • In an encrypted room, users without a matrix rtc membership cannot get the call keys, so their streams will be irrelevant anyways + they cannot do anything with the stream from others. -> there is no reason to add them as tiles.
image image

@CLAassistant
Copy link

CLAassistant commented Oct 30, 2024

CLA assistant check
All committers have signed the CLA.

@toger5 toger5 force-pushed the toger5/tiles_based_on_rtc_member branch from 0b52f39 to 2a5dc60 Compare November 4, 2024 14:38
@toger5 toger5 changed the title make tiles based on rtc member Make tiles be based on rtc member Nov 4, 2024
@toger5 toger5 changed the title Make tiles be based on rtc member Make tiles be based on RTC member Nov 4, 2024
hughns added a commit that referenced this pull request Dec 2, 2024
This is based on top of #2701
@hughns
Copy link
Member

hughns commented Dec 2, 2024

One "rough edge" on this is that when a remote participant leaves the call, they are shown as "Waiting for media..." whilst the animation to remove the tile from the screen is playing.

This is fixed indirectly using the animated loading border,

The "animated loading border" is now in #2858 for consideration.

@hughns
Copy link
Member

hughns commented Dec 4, 2024

This is ready for the next round of review.

@hughns
Copy link
Member

hughns commented Dec 4, 2024

With regards to the visual design/representation: I think we should get it merged as-is (with the "Waiting for media...") and then tackle the representation before we do a release.

src/state/CallViewModel.ts Outdated Show resolved Hide resolved
Copy link
Contributor Author

@toger5 toger5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I cannot approve my own PR ;) So @hughns you need to approve on my behave

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants