-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make tiles be based on RTC member #2701
base: livekit
Are you sure you want to change the base?
Conversation
6a014ef
to
246aab7
Compare
0b52f39
to
2a5dc60
Compare
The "animated loading border" is now in #2858 for consideration. |
This reverts commit 765f7b4.
This is ready for the next round of review. |
With regards to the visual design/representation: I think we should get it merged as-is (with the "Waiting for media...") and then tackle the representation before we do a release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I cannot approve my own PR ;) So @hughns you need to approve on my behave
Co-authored-by: Timo <16718859+toger5@users.noreply.github.com>
Currently a tile is shown whenever livekit has a participant.
This is wrong in a couple of situations: