Replace device dropdowns with radio buttons #2803
Conversation
|
Do you think this is the right place to also work on the default device bahaviour? |
| {!isFirefox() && ( | ||
| <DeviceSelection | ||
| devices={devices.audioOutput} | ||
| caption={t("settings.speaker_device_selection_label")} | ||
| /> | ||
| )} | ||
| <div className={styles.volumeSlider}> |
There was a problem hiding this comment.
I think this might not be needed. (anymore)
This is what i get with the WebRtc test page https://webrtc.github.io/samples/src/content/devices/input-output/
It seems like both platforms support input and output devices.
Chrome
Firefox
There was a problem hiding this comment.
But I am not sure how much of the output selection even works. On linux It seems like I mostly just use the system level output/input.
There was a problem hiding this comment.
Past me says that we were waiting for Firefox 123 in order to turn it back on: #2022 (comment) so I'll do so in a follow-up PR.
This is closer to what the designs actually want device settings to look like, and it avoids the visual glitch in which the dropdown would render underneath the slider.
I'd like to avoid adding a switch that blocks you from changing your device until it's turned off. But perhaps we could normalize the behavior between Firefox and Chrome by adding a virtual 'Default' device in Firefox? If that sounds appropriate to you I could work on that in a later PR. |
robintown
force-pushed
the
device-radio
branch
from
fd9de43
to
38085ba
Compare
|
This works really great! Code looks good and I tested it a bit. |
This is closer to what the designs actually want device settings to look like, and it avoids the visual glitch in which the dropdown would render underneath the slider.