-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add background blur feature for supported devices #2812
base: livekit
Are you sure you want to change the base?
Conversation
how do we deal with lk modules that dont fullfill the ts lints? |
18af76e
to
2830224
Compare
f76fc2d
to
21230ee
Compare
I found what we needed: |
2daf807
to
00b500b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested some cleanup. Furthermore I think you could deduplicate some of the code into something like a useBlur()
or canBlur()
. This might make adding tests easier too.
8f5aca9
to
3f85d8a
Compare
I think @robintown has an idea how we might be able to reuse the track from the lobby to the in call view. Than this might come for free. But in this pr we should at least get rid of the duplicated |
@@ -150,6 +150,9 @@ | |||
"effect_volume_description": "Adjust the volume at which reactions and hand raised effects play", | |||
"effect_volume_label": "Sound effect volume" | |||
}, | |||
"background_blur_header": "Background", | |||
"background_blur_label": "Blur the background of the video", | |||
"blur_not_supported_by_browser": "(Background blur is not supported by this browser)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"blur_not_supported_by_browser": "(Background blur is not supported by this browser)", | |
"blur_not_supported_by_browser": "(Background blur is not supported by this device)", |
...because this message also appears when EC is embedded as widget and the user isn't aware that it is a browser.
This adds background blur via @livekit/track-processors for supported browsers.
The option can be found in the video tab of the settings.
The fallback will be a greyed out checkbox (on firefox for instance)
This way firefox users get informed why it does not work on their side if other users tell them where to set it up.
Sadly this is not exactly done the way we would want to set it up see: livekit/track-processors-js#50