-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for playing a sound when the user exits a call. #2860
Open
Half-Shot
wants to merge
25
commits into
livekit
Choose a base branch
from
hs/leave-call-sound
base: livekit
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−30
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
b8597b5
Refactor to use AudioContext
Half-Shot c3cf755
Remove unused audio format.
Half-Shot 3d89b10
Reduce update frequency for volume
Half-Shot fc0bc1a
Port to useAudioContext
Half-Shot 719e6e7
Port reactionaudiorenderer to useAudioContext
Half-Shot 0c331a0
Integrate raise hand sound into call event renderer.
Half-Shot 2a45be8
Simplify reaction sounds
Half-Shot 4d5a543
only play one sound per reaction type
Half-Shot a5c3d5c
Start to build out tests
Half-Shot d885728
fixup tests / comments
Half-Shot 0139499
Fix reaction sound
Half-Shot 983afc6
remove console line
Half-Shot cc7ed79
Remove another debug line.
Half-Shot 923b548
fix lint
Half-Shot 0adacd0
Use testing library click
Half-Shot 1f33180
lint
Half-Shot 2336046
Add support for playing a sound when the user exits a call.
Half-Shot 2f393d0
Port GroupCallView to useAudioContext
Half-Shot a3723b7
Remove debug bits.
Half-Shot c7a56f7
asyncify
Half-Shot c5f297d
lint
Half-Shot b7f55a4
lint
Half-Shot 59e8e76
merge
Half-Shot 30ca842
lint
Half-Shot 950bd33
tidy
Half-Shot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.