Show tiles for members we're trying to connect to #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbkr
added
the
T-Defect
dbkr
commented
Oct 21, 2022
| @@ -76,7 +76,6 @@ export function GroupCallView({ | |||
| toggleScreensharing, | |||
| requestingScreenshare, | |||
| isScreensharing, | |||
| localScreenshareFeed, | |||
dbkr
commented
Oct 21, 2022
| export interface Participant { | ||
| // Represents something that should get a tile on the layout, | ||
| // ie. a user's video feed or a screen share feed. | ||
| export interface TileDescriptor { |
There was a problem hiding this comment.
Renamed to try & resolve naming conflict as the list of room members was also called 'participants'. These aren't really participants as they also include extra tiles for the screenshares.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help give more context on what's going wrong in splitbrain scenarios.
If users leave calls uncleanly, their tile will remain in until their member event times out, which will be an hour from when they joined the call. See #639.
Part of #616