Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libsqlcipher0 to Depends for DEB packages #1234

Closed
wants to merge 2 commits into from
Closed

Add libsqlcipher0 to Depends for DEB packages #1234

wants to merge 2 commits into from

Conversation

pludi
Copy link

@pludi pludi commented Sep 19, 2023

Checklist

  • Ensure your code works with manual testing
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Based on the information from #1233 I checked for the inclusion of libsqlcipher0 in Debian-based distributions. Debian itself includes it since Buster (mid 2019), and all currently supported Debian and Ubuntu versions ship it. Checking the package databases of major Debian/Ubuntu derivates (Linux Mint, MX Linux, Pop_OS!, Devuan, antiX) shows them either shipping it too or pulling it from the Ubuntu repos.


This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@pludi pludi requested review from a team as code owners September 19, 2023 08:39
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Sep 19, 2023
@t3chguy
Copy link
Member

t3chguy commented Sep 19, 2023

Debian itself includes it since Buster (mid 2019)

Debian Stretch & Jessie are still supported in ELTS
https://www.freexian.com/lts/extended/docs/debian-9-support/
https://www.freexian.com/lts/extended/docs/debian-8-support/

Checking the package databases of major Debian/Ubuntu derivates (Linux Mint, MX Linux, Pop_OS!, Devuan, antiX) shows them either shipping it too or pulling it from the Ubuntu repos.

Sure but we try to support more than just that list of major derivatives you came up with, one random example, looks like deepin lacks a libsqlcipher0

https://community-packages.deepin.com/deepin/pool/main/libs/

@richvdh richvdh removed their request for review September 19, 2023 11:12
@pludi
Copy link
Author

pludi commented Sep 19, 2023

Deepin has the libsqlcipher0 package, just at a different location: https://community-packages.deepin.com/deepin/apricot/pool/main/s/sqlcipher/

Regarding Debian 8 and 9, that service apparently isn't for the whole distribution, but instead customers have to provide a list of required packages. As such I'd wager that anyone running Element Desktop on such an old machine and with the requirement for cipher message search probably already has it requested from them and/or installed through other means.

@t3chguy
Copy link
Member

t3chguy commented Sep 19, 2023

It is worth noting that the dependency is on its way out with us wanting to move to static sqlcipher linking #1001

@pludi pludi closed this by deleting the head repository Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants