Enable generic secrets in keytar via ipc

[Nils1729]

This PR implements an extended IPC interface (element-hq/element-web#26405) between the electron platform and application. The interface can be used to set, retrieve and destroy arbitrary secrets, similar to saving pickle keys. Notably, these changes allow setting a value for a secret instead of just generating a random one and retrieving it. See also matrix-org/matrix-react-sdk#11776.

Checklist

• Ensure your code works with manual testing
• Linter and other CI checks pass
• Sign-off given on the changes (see CONTRIBUTING.md)

Notes: none

---

This change has no change notes, so will not be included in the changelog.

[t3chguy]

It'd be good to avoid using keytar for new secrets code, can you use https://www.electronjs.org/docs/latest/api/safe-storage instead?

[Nils1729]

It'd be good to avoid using keytar for new secrets code, can you use https://www.electronjs.org/docs/latest/api/safe-storage instead?

I can try to do that from the current branch, but the implementation would greatly benefit from parts of #1087. Is there any timeline for that PR?

[t3chguy]

@Johennes is currently looking into scheduling for that work to continue, keep in mind that PR hasn't yet been tested, otherwise feel free to cargocult whatever you deem useful

[Johennes]

Sadly, the keytar deprecation topic sits further down in our backlog right now. We'll probably not be able to pick this up ourselves in the near future but contributions would certainly be welcome.

[Nils1729]

I switched to a minimal setup with safeStorage. Note that the code uses a different store from global.store because the security assumptions are different and explicit exceptions to the global.store.clear() on logout would probably not play nicely with the rest.

[t3chguy]

This should be your copyright

[t3chguy]

Hmm, what is the reason for this? This doesn't seem desirable, we go out of our way to clear all data when you log out using electron-clear-data via the clearStorage IPC

[Nils1729]

Of couse we can only do this on a trusted platform/filesystem, I am aware this is against the spirit of the remaining code base, thus the comment.

The feature of this PR is intended for use in matrix-org/matrix-react-sdk#11776 (Store the ssss key on the platform so it is easier to use and harder to lose). Not clearing the key reduces friction, as it enables a user to log into Element again and have the device automatically verified.

What if we make clearing the secrets a feature flag that explicitly warn about the implications?

[t3chguy]

Yeah as it stands this would need product buy-in, right now its intentional that a log out wipes as much as possible.