Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check for updates if we already have one downloaded and queued #386

Merged
merged 2 commits into from
Jul 4, 2022
Merged

Don't check for updates if we already have one downloaded and queued #386

merged 2 commits into from
Jul 4, 2022

Conversation

ara4n
Copy link
Member

@ara4n ara4n commented Jul 3, 2022 •
edited by github-actions bot
Loading

This is a punt at fixing element-hq/element-web#12433,
on the assumption that multiple update checks might collide with a
download which are already queued to install. It also avoids repeatedly
re-downloading the same update on every check, as per the Note: on
https://github.com/electron/electron/blob/main/docs/api/auto-updater.md#autoupdatercheckforupdates

However, it means that you may have to upgrade twice if you wait more than 24h to install
a new build (once for the old build, and once for the latest build)- and if you cancel an upgrade prompt,
you'll have to either restart the app or explicitly check for a new version to get upgrades working again.
However, this is less annoying than having the app fail to relaunch after upgrading.
The double-install (mis)behaviour also seems to exist today.

Here's what your changelog entry will look like:

🐛 Bug Fixes

  • Don't check for updates if we already have one downloaded and queued (#386).

@ara4n
Don't check for updates if we already have one downloaded and queued
45a9156 
This is a punt at fixing element-hq/element-web#12433,
on the assumption that multiple update checks might collide with a
download which are already queued to install.  It also avoids repeatedly
re-downloading the same update on every check, as per the Note: on
https://github.com/electron/electron/blob/main/docs/api/auto-updater.md#autoupdatercheckforupdates

However, it means that you may have to upgrade twice if you wait more than 24h to install
a new build - and if you cancel an upgrade prompt, you'll have to either restart
the app or explicitly check for a new version to get upgrades working again.
However, this is less annoying than having the app fail to relaunch after upgrading.
@ara4n ara4n requested a review from a team as a code owner July 3, 2022 15:40
@ara4n ara4n mentioned this pull request Jul 3, 2022
Closed
@ara4n ara4n added the T-Defect label Jul 4, 2022
@ara4n ara4n merged commit 9bd927f into develop Jul 4, 2022
@ara4n ara4n deleted the matthew/fix-updates branch July 4, 2022 09:26
@t3chguy t3chguy mentioned this pull request Jul 11, 2022
Closed
su-ex added a commit to SchildiChat/element-desktop that referenced this pull request Aug 1, 2022
@su-ex
Merge tag 'v1.11.1' into sc
e65c31b 
* Enable URL tooltips on hover for Element Desktop ([\#22286](element-hq/element-web#22286)). Fixes undefined/element-web#6532.
* Hide screenshare button in video rooms on Desktop ([\#9045](matrix-org/matrix-react-sdk#9045)).
* Add a developer command to reset Megolm and Olm sessions ([\#9044](matrix-org/matrix-react-sdk#9044)).
* add spaces to TileErrorBoundary ([\#9012](matrix-org/matrix-react-sdk#9012)). Contributed by @HarHarLinks.
* Location sharing - add localised strings to map ([\#9025](matrix-org/matrix-react-sdk#9025)). Fixes element-hq/element-web#21443. Contributed by @kerryarchibald.
* Added trim to ignore whitespaces in email check ([\#9027](matrix-org/matrix-react-sdk#9027)). Contributed by @ankur12-1610.
* Improve _GenericEventListSummary.scss ([\#9005](matrix-org/matrix-react-sdk#9005)). Contributed by @luixxiul.
* Live location share - tiles without tile server (PSG-591) ([\#8962](matrix-org/matrix-react-sdk#8962)). Contributed by @kerryarchibald.
* Add option to display tooltip on link hover ([\#8394](matrix-org/matrix-react-sdk#8394)). Fixes element-hq/element-web#21907.
* Support a module API surface for custom functionality ([\#8246](matrix-org/matrix-react-sdk#8246)).
* Adjust encryption copy when creating a video room ([\#8989](matrix-org/matrix-react-sdk#8989)). Fixes element-hq/element-web#22737.
* Add bidirectonal isolation for pills ([\#8985](matrix-org/matrix-react-sdk#8985)). Contributed by @sha-265.
* Delabs `Show current avatar and name for users in message history` ([\#8764](matrix-org/matrix-react-sdk#8764)). Fixes element-hq/element-web#22336.
* Live location share - open latest location in map site ([\#8981](matrix-org/matrix-react-sdk#8981)). Contributed by @kerryarchibald.
* Improve LinkPreviewWidget ([\#8881](matrix-org/matrix-react-sdk#8881)). Fixes element-hq/element-web#22634. Contributed by @luixxiul.
* Render HTML topics in rooms on space home ([\#8939](matrix-org/matrix-react-sdk#8939)).
* Hide timestamp on event tiles being edited on every layout ([\#8956](matrix-org/matrix-react-sdk#8956)). Contributed by @luixxiul.
* Introduce new copy icon ([\#8942](matrix-org/matrix-react-sdk#8942)).
* Allow finding group DMs by members in spotlight ([\#8922](matrix-org/matrix-react-sdk#8922)). Fixes element-hq/element-web#22564. Contributed by @justjanne.
* Live location share - explicitly stop beacons replaced beacons ([\#8933](matrix-org/matrix-react-sdk#8933)). Contributed by @kerryarchibald.
* Remove unpin from widget kebab menu ([\#8924](matrix-org/matrix-react-sdk#8924)).
* Live location share - redact related locations on beacon redaction ([\#8926](matrix-org/matrix-react-sdk#8926)). Contributed by @kerryarchibald.
* Live location share - disallow message pinning ([\#8928](matrix-org/matrix-react-sdk#8928)). Contributed by @kerryarchibald.
* Fix manual update checks not working after being dismissed ([\element-hq#388](element-hq#388)). Fixes element-hq/element-web#22795.
* Don't check for updates if we already have one downloaded and queued ([\element-hq#386](element-hq#386)).
* Fix default file name in save-image-as ([\element-hq#385](element-hq#385)). Fixes element-hq/element-web#20838.
* Remove the ability to hide yourself in video rooms ([\#22806](element-hq/element-web#22806)). Fixes element-hq/element-web#22805.
* Unbreak in-app permalink tooltips  ([\#9100](matrix-org/matrix-react-sdk#9100)).
* Add space for the stroke on message editor on IRC layout ([\#9030](matrix-org/matrix-react-sdk#9030)). Fixes element-hq/element-web#22785. Contributed by @luixxiul.
* Fix pinned messages not re-linkifying on edit ([\#9042](matrix-org/matrix-react-sdk#9042)). Fixes element-hq/element-web#22726.
* Don't unnecessarily persist the host signup dialog ([\#9043](matrix-org/matrix-react-sdk#9043)). Fixes element-hq/element-web#22778.
* Fix URL previews causing messages to become unrenderable ([\#9028](matrix-org/matrix-react-sdk#9028)). Fixes element-hq/element-web#22766.
* Fix event list summaries including invalid events ([\#9041](matrix-org/matrix-react-sdk#9041)). Fixes element-hq/element-web#22790.
* Correct accessibility labels for unread rooms in spotlight ([\#9003](matrix-org/matrix-react-sdk#9003)). Contributed by @justjanne.
* Enable search strings highlight on bubble layout ([\#9032](matrix-org/matrix-react-sdk#9032)). Fixes element-hq/element-web#22786. Contributed by @luixxiul.
* Unbreak URL preview for formatted links with tooltips ([\#9022](matrix-org/matrix-react-sdk#9022)). Fixes element-hq/element-web#22764.
* Re-add margin to tiles based on EventTileBubble ([\#9015](matrix-org/matrix-react-sdk#9015)). Fixes element-hq/element-web#22772. Contributed by @luixxiul.
* Fix Shortcut prompt for Search showing in minimized Roomlist ([\#9014](matrix-org/matrix-react-sdk#9014)). Fixes element-hq/element-web#22739. Contributed by @justjanne.
* Fix avatar position on event info line for hidden events on a thread ([\#9019](matrix-org/matrix-react-sdk#9019)). Fixes element-hq/element-web#22777. Contributed by @luixxiul.
* Fix lost padding of event tile info line ([\#9009](matrix-org/matrix-react-sdk#9009)). Fixes element-hq/element-web#22754 and element-hq/element-web#22759. Contributed by @luixxiul.
* Align verification bubble with normal event tiles on IRC layout ([\#9001](matrix-org/matrix-react-sdk#9001)). Fixes element-hq/element-web#22758. Contributed by @luixxiul.
* Ensure timestamp on generic event list summary is not hidden from TimelineCard ([\#9000](matrix-org/matrix-react-sdk#9000)). Fixes element-hq/element-web#22755. Contributed by @luixxiul.
* Fix headings margin on security user settings tab ([\#8826](matrix-org/matrix-react-sdk#8826)). Contributed by @luixxiul.
* Fix timestamp position on file panel ([\#8976](matrix-org/matrix-react-sdk#8976)). Fixes element-hq/element-web#22718. Contributed by @luixxiul.
* Stop using :not() pseudo class for mx_GenericEventListSummary ([\#8944](matrix-org/matrix-react-sdk#8944)). Fixes element-hq/element-web#22602. Contributed by @luixxiul.
* Don't show the same user twice in Spotlight ([\#8978](matrix-org/matrix-react-sdk#8978)). Fixes element-hq/element-web#22697.
* Align the right edge of expand / collapse link buttons of generic event list summary in bubble layout with a variable ([\#8992](matrix-org/matrix-react-sdk#8992)). Fixes element-hq/element-web#22743. Contributed by @luixxiul.
* Display own avatars on search results panel in bubble layout ([\#8990](matrix-org/matrix-react-sdk#8990)). Contributed by @luixxiul.
* Fix text flow of thread summary content on threads list ([\#8991](matrix-org/matrix-react-sdk#8991)). Fixes element-hq/element-web#22738. Contributed by @luixxiul.
* Fix the size of the clickable area of images ([\#8987](matrix-org/matrix-react-sdk#8987)). Fixes element-hq/element-web#22282.
* Fix font size of MessageTimestamp on TimelineCard ([\#8950](matrix-org/matrix-react-sdk#8950)). Contributed by @luixxiul.
* Improve security room settings tab style rules ([\#8844](matrix-org/matrix-react-sdk#8844)). Fixes element-hq/element-web#22575. Contributed by @luixxiul.
* Align E2E icon and avatar of info tile in compact modern layout ([\#8965](matrix-org/matrix-react-sdk#8965)). Fixes element-hq/element-web#22652. Contributed by @luixxiul.
* Fix clickable area of general event list summary toggle ([\#8979](matrix-org/matrix-react-sdk#8979)). Fixes element-hq/element-web#22722. Contributed by @luixxiul.
* Fix resizing room topic ([\#8966](matrix-org/matrix-react-sdk#8966)). Fixes element-hq/element-web#22689.
* Dismiss the search dialogue when starting a DM ([\#8967](matrix-org/matrix-react-sdk#8967)). Fixes element-hq/element-web#22700.
* Fix "greyed out" text style inconsistency on search result panel ([\#8974](matrix-org/matrix-react-sdk#8974)). Contributed by @luixxiul.
* Add top padding to EventTilePreview loader ([\#8977](matrix-org/matrix-react-sdk#8977)). Fixes element-hq/element-web#22719. Contributed by @luixxiul.
* Fix read receipts group position on TimelineCard in compact modern/group layout ([\#8971](matrix-org/matrix-react-sdk#8971)). Fixes element-hq/element-web#22715. Contributed by @luixxiul.
* Fix calls on homeservers without the unstable thirdparty endpoints. ([\#8931](matrix-org/matrix-react-sdk#8931)). Fixes element-hq/element-web#21680. Contributed by @deepbluev7.
* Enable ReplyChain text to be expanded on IRC layout ([\#8959](matrix-org/matrix-react-sdk#8959)). Fixes element-hq/element-web#22709. Contributed by @luixxiul.
* Fix hidden timestamp on message edit history dialog ([\#8955](matrix-org/matrix-react-sdk#8955)). Fixes element-hq/element-web#22701. Contributed by @luixxiul.
* Enable ReplyChain text to be expanded on bubble layout ([\#8958](matrix-org/matrix-react-sdk#8958)). Fixes element-hq/element-web#22709. Contributed by @luixxiul.
* Fix expand/collapse state wrong in metaspaces ([\#8952](matrix-org/matrix-react-sdk#8952)). Fixes element-hq/element-web#22632.
* Location (live) share replies now provide a fallback content ([\#8949](matrix-org/matrix-react-sdk#8949)).
* Fix space settings not opening for script-created spaces ([\#8957](matrix-org/matrix-react-sdk#8957)). Fixes element-hq/element-web#22703.
* Respect `filename` field on `m.file` events ([\#8951](matrix-org/matrix-react-sdk#8951)).
* Fix PlatformSettingsHandler always returning true due to returning a Promise ([\#8954](matrix-org/matrix-react-sdk#8954)). Fixes element-hq/element-web#22616.
* Improve high-contrast support for spotlight ([\#8948](matrix-org/matrix-react-sdk#8948)). Fixes element-hq/element-web#22481. Contributed by @justjanne.
* Fix wrong assertions that all media events have a mimetype ([\#8946](matrix-org/matrix-react-sdk#8946)). Fixes matrix-org/element-web-rageshakes#13727.
* Make invite dialogue fixed height ([\#8934](matrix-org/matrix-react-sdk#8934)). Fixes element-hq/element-web#22659.
* Fix all megolm error reported as unknown ([\#8916](matrix-org/matrix-react-sdk#8916)).
* Remove line-height declarations from _ReplyTile.scss ([\#8932](matrix-org/matrix-react-sdk#8932)). Fixes element-hq/element-web#22687. Contributed by @luixxiul.
* Reduce video rooms log spam ([\#8913](matrix-org/matrix-react-sdk#8913)).
* Correct new search input’s rounded corners ([\#8921](matrix-org/matrix-react-sdk#8921)). Fixes element-hq/element-web#22576. Contributed by @justjanne.
* Align unread notification dot on threads list in compact modern=group layout ([\#8911](matrix-org/matrix-react-sdk#8911)). Fixes element-hq/element-web#22677. Contributed by @luixxiul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weeman1337 weeman1337 weeman1337 approved these changes

@dbkr dbkr dbkr approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from element-hq/element-web-reviewers

@justjanne justjanne Awaiting requested review from justjanne justjanne is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ara4n @dbkr @weeman1337