Use Xenial as the build image's base distribution #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Xenial has the oldest glibc (2.23) of all the active distributions, this attempts to construct a build image based on that. The Dockerfile here was built by recursively expanding the `FROM` lines until reaching `buildpack-deps:bionic-curl` and then changing that to `xenial`. Everything else is the same. Part of element-hq/element-web#13553
|
We should probably merge the apt-get libsqlcipher into the other apt-get so we only update & purge once. Also looks like the linter is broken? |
Yeah, filed element-hq/element-web#13584 on this. |
dbkr
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Xenial has the oldest glibc (2.23) of all the active distributions, this
attempts to construct a build image based on that. The Dockerfile here was built
by recursively expanding the
FROMlines until reachingbuildpack-deps:bionic-curland then changing that toxenial. Everything elseis the same.
@cknoll has tested a nightly build prepared this way, and verified it fixes the segfault.
Part of element-hq/element-web#13553