-
Notifications
You must be signed in to change notification settings - Fork 489
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update suggested room preview to behave the same way in all cases #5771
- Done
- Loading branch information
Showing
6 changed files
with
145 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
113 changes: 113 additions & 0 deletions
113
...dules/Spaces/SpaceRoomList/SpaceChildRoomDetail/SpaceChildRoomDetailBridgePresenter.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| /* | ||
| Copyright 2021 New Vector Ltd | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| import Foundation | ||
|
|
||
| @objc protocol SpaceChildRoomDetailBridgePresenterDelegate { | ||
| func spaceChildRoomDetailBridgePresenter(_ coordinator: SpaceChildRoomDetailBridgePresenter, didOpenRoomWith roomId: String) | ||
| func spaceChildRoomDetailBridgePresenterDidCancel(_ coordinator: SpaceChildRoomDetailBridgePresenter) | ||
| } | ||
|
|
||
| /// SpaceChildRoomDetailBridgePresenter enables to start SpaceChildRoomDetailCoordinator from a view controller. | ||
| /// This bridge is used while waiting for global usage of coordinator pattern. | ||
| /// It breaks the Coordinator abstraction and it has been introduced for Objective-C compatibility (mainly for integration in legacy view controllers). Each bridge should be removed once the underlying Coordinator has | ||
| /// been integrated by another Coordinator. | ||
| @objcMembers | ||
| final class SpaceChildRoomDetailBridgePresenter: NSObject { | ||
|
|
||
| // MARK: - Properties | ||
|
|
||
| // MARK: Private | ||
|
|
||
| private let session: MXSession | ||
| private let childInfo: MXSpaceChildInfo | ||
| private var coordinator: SpaceChildRoomDetailCoordinator? | ||
| private lazy var slidingModalPresenter: SlidingModalPresenter = { | ||
| return SlidingModalPresenter() | ||
| }() | ||
|
|
||
| // MARK: Public | ||
|
|
||
| weak var delegate: SpaceChildRoomDetailBridgePresenterDelegate? | ||
|
|
||
| // MARK: - Setup | ||
|
|
||
| init(session: MXSession, childInfo: MXSpaceChildInfo) { | ||
| self.session = session | ||
| self.childInfo = childInfo | ||
| super.init() | ||
| } | ||
|
|
||
| // MARK: - Public | ||
|
|
||
| // NOTE: Default value feature is not compatible with Objective-C. | ||
| // func present(from viewController: UIViewController, animated: Bool) { | ||
| // self.present(from: viewController, animated: animated) | ||
| // } | ||
|
|
||
| func present(from viewController: UIViewController, sourceView: UIView?, animated: Bool) { | ||
| let coordinator = SpaceChildRoomDetailCoordinator(parameters: SpaceChildRoomDetailCoordinatorParameters(session: session, childInfo: childInfo)) | ||
| coordinator.delegate = self | ||
| coordinator.start() | ||
|
|
||
| self.coordinator = coordinator | ||
|
|
||
| if UIDevice.current.isPhone || sourceView == nil { | ||
| slidingModalPresenter.present(coordinator.toSlidingPresentable(), from: viewController, animated: animated, completion: nil) | ||
| } else { | ||
| let presentable = coordinator.toPresentable() | ||
| presentable.modalPresentationStyle = .popover | ||
| if let sourceView = sourceView, let popoverPresentationController = presentable.popoverPresentationController { | ||
| popoverPresentationController.sourceView = sourceView | ||
| popoverPresentationController.sourceRect = sourceView.bounds | ||
| } | ||
|
|
||
| viewController.present(presentable, animated: true) | ||
| } | ||
| } | ||
|
|
||
| func dismiss(animated: Bool, completion: (() -> Void)?) { | ||
| guard let coordinator = self.coordinator else { | ||
| return | ||
| } | ||
| coordinator.toPresentable().dismiss(animated: animated) { | ||
| self.coordinator = nil | ||
|
|
||
| if let completion = completion { | ||
| completion() | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // MARK: - SpaceChildRoomDetailCoordinatorDelegate | ||
| extension SpaceChildRoomDetailBridgePresenter: SpaceChildRoomDetailCoordinatorDelegate { | ||
| func spaceChildRoomDetailCoordinator(_ coordinator: SpaceChildRoomDetailCoordinatorType, didOpenRoomWith roomId: String) { | ||
| delegate?.spaceChildRoomDetailBridgePresenter(self, didOpenRoomWith: roomId) | ||
| } | ||
|
|
||
| func spaceChildRoomDetailCoordinatorDidCancel(_ coordinator: SpaceChildRoomDetailCoordinatorType) { | ||
| delegate?.spaceChildRoomDetailBridgePresenterDidCancel(self) | ||
| } | ||
| } | ||
|
|
||
| // MARK: - UIAdaptivePresentationControllerDelegate | ||
| extension SpaceChildRoomDetailBridgePresenter: UIAdaptivePresentationControllerDelegate { | ||
|
|
||
| func presentationControllerDidDismiss(_ presentationController: UIPresentationController) { | ||
| delegate?.spaceChildRoomDetailBridgePresenterDidCancel(self) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Update suggested room preview to behave the same way in all cases | ||
|
|