Fix performance issues with Spaces on very large accounts #4898

- Support optional `MXSpace.room` property
element-hq · Oct 7, 2021 · 9e33172 · 9e33172
1 parent b8949fb
commit 9e33172
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/Riot/Modules/Spaces/SpaceDetail/SpaceDetailViewController.swift b/Riot/Modules/Spaces/SpaceDetail/SpaceDetailViewController.swift
@@ -231,9 +231,6 @@ class SpaceDetailViewController: UIViewController {
         let membersString = membersCount == 1 ? VectorL10n.roomTitleOneMember : VectorL10n.roomTitleMembers("\(membersCount)")
         self.spaceTypeLabel.text = "\(joinRuleString) · \(membersString)"
 
-        let joinRuleIcon = parameters.joinRule == .public ? Asset.Images.spaceTypeIcon : Asset.Images.spacePrivateIcon
-        self.spaceTypeIconView.image = joinRuleIcon.image
-
         self.inviterIdLabel.text = parameters.inviterId
         if let inviterId = parameters.inviterId {
             self.inviterTitleLabel.text = "\(parameters.inviter?.displayname ?? inviterId) invited you"

diff --git a/Riot/Modules/Spaces/SpaceDetail/SpaceDetailViewModel.swift b/Riot/Modules/Spaces/SpaceDetail/SpaceDetailViewModel.swift
@@ -80,7 +80,7 @@ class SpaceDetailViewModel: SpaceDetailViewModelType {
             self.update(viewState: .loaded(parameters))
 
             self.update(viewState: .loading)
-            space.room.state { state in
+            space.room?.state { state in
                 let joinRule = state?.joinRule
                 let membersCount = summary.membersCount.members