/issues/4753 - Allow audio file attachments to be played back inline …

…by reusing the existing voice message UI.
element-hq · Dec 2, 2021 · eb8d782 · eb8d782
1 parent 67c5bff
commit eb8d782
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/Riot/Modules/Room/RoomViewController.m b/Riot/Modules/Room/RoomViewController.m
@@ -2690,7 +2690,7 @@ - (void)displayRoomPreview:(RoomPreviewData *)previewData
         {
             cellViewClass = RoomGroupCallStatusBubbleCell.class;
         }
-        else if (bubbleData.attachment.type == MXKAttachmentTypeVoiceMessage)
+        else if (bubbleData.attachment.type == MXKAttachmentTypeVoiceMessage || bubbleData.attachment.type == MXKAttachmentTypeAudio)
         {
             if (bubbleData.isPaginationFirstBubble)
             {

diff --git a/Riot/Modules/Room/Views/BubbleCells/VoiceMessage/VoiceMessageBubbleCell.swift b/Riot/Modules/Room/Views/BubbleCells/VoiceMessage/VoiceMessageBubbleCell.swift
@@ -27,7 +27,7 @@ class VoiceMessageBubbleCell: SizableBaseBubbleCell, BubbleCellReactionsDisplaya
             return
         }
 
-        guard data.attachment.type == MXKAttachmentTypeVoiceMessage else {
+        guard data.attachment.type == MXKAttachmentTypeVoiceMessage || data.attachment.type == MXKAttachmentTypeAudio else {
             fatalError("Invalid attachment type passed to a voice message cell.")
         }
 

diff --git a/Riot/Modules/Room/VoiceMessages/VoiceMessageAttachmentCacheManager.swift b/Riot/Modules/Room/VoiceMessages/VoiceMessageAttachmentCacheManager.swift
@@ -85,7 +85,7 @@ class VoiceMessageAttachmentCacheManager {
     }
 
     func loadAttachment(_ attachment: MXKAttachment, numberOfSamples: Int, completion: @escaping (Result<VoiceMessageAttachmentCacheManagerLoadResult, Error>) -> Void) {
-        guard attachment.type == MXKAttachmentTypeVoiceMessage else {
+        guard attachment.type == MXKAttachmentTypeVoiceMessage || attachment.type == MXKAttachmentTypeAudio else {
             completion(Result.failure(VoiceMessageAttachmentCacheManagerError.invalidAttachmentType))
             MXLog.error("[VoiceMessageAttachmentCacheManager] Invalid attachment type, ignoring request.")
             return

diff --git a/changelog.d/4753.feature b/changelog.d/4753.feature
@@ -0,0 +1 @@
+Allow audio file attachments to be played back inline by reusing the existing voice message UI.