Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room upgrade UI leaks raw room IDs and fails on federated servers. #2486

Closed
ara4n opened this issue Jun 12, 2019 · 3 comments · Fixed by #2569
Closed

Room upgrade UI leaks raw room IDs and fails on federated servers. #2486

ara4n opened this issue Jun 12, 2019 · 3 comments · Fixed by #2569
Assignees
@manuroe
Labels
A-Room-Upgrades P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Milestone
Sprint 20

Comments

@ara4n
Copy link
Member

ara4n commented Jun 12, 2019

I followed a "this room is upgraded!" link on iOS, which then prompted me to manually accept the invite for the new room.
a) Shouldn't it automatically accept the invite for me, if i've clicked the 'this room is upgraded' prompt?
b) The invite UI was exclusively in terms of !78y91243qwrfiuhsd:matrix.org style ugly room IDs, which was made for a very bad UX.
@ara4n ara4n changed the title Room upgrade UI leaks raw room IDs Room upgrade UI leaks raw room IDs and fails on federated servers. Jun 12, 2019
@ara4n
Copy link
Member Author

ara4n commented Jun 12, 2019

actually, it's worse than that, as the fact it's obsessed with room IDs means that it can't join upgraded rooms which don't yet exist on your local server:

room upgrade fail

@ara4n ara4n mentioned this issue Jun 13, 2019
Closed
@ara4n ara4n added P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems labels Jun 13, 2019
@aaronraimist
Copy link
Contributor

I'm guessing this is just #1066 still existing

@manuroe
Copy link
Member

manuroe commented Jul 8, 2019

#1066 fixes the error when joining the room.

@manuroe manuroe added this to the Sprint 20 milestone Jul 10, 2019
@manuroe manuroe self-assigned this Jul 10, 2019
manuroe added a commit that referenced this issue Jul 10, 2019
@manuroe
Room upgrade: Autojoin the upgraded room when the user taps on the to…
d7112be 
…mbstone banner

#2486
manuroe added a commit that referenced this issue Jul 10, 2019
@manuroe
Room upgrade: Autojoin the upgraded room when the user taps on the to…
54af44d 
…mbstone banner

#2486
@manuroe manuroe mentioned this issue Jul 10, 2019
Merged
@julianfoad julianfoad mentioned this issue Jun 13, 2019
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manuroe manuroe

Labels
A-Room-Upgrades P1 T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
Sprint 20
3 participants
@ara4n @aaronraimist @manuroe