Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space home view inherits title from previously viewed tab #4851

Closed
kittykat opened this issue Sep 16, 2021 · 0 comments
Closed

Space home view inherits title from previously viewed tab #4851

kittykat opened this issue Sep 16, 2021 · 0 comments
Assignees
@kittykat @gileluard
Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Release-Blocker Z-Spaces-Testing

Comments

@kittykat
Copy link
Contributor

Steps to reproduce

  1. In a space, navigate to a tab which isn't home (e.g. room list or member list)
  2. Navigate to the home view for that space

What happened?

What did you expect?

Tab title updates to space name or Explore space or something like that.

What happened?

Title was inherited from previously viewed tab.

Your phone model

No response

Operating system version

14.6

Application version

1.5.4 (Gil's version for testing spaces)

Homeserver

No response

Have you submitted a rageshake?

No
@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Spaces Spaces, groups, communities S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-Spaces-Testing labels Sep 16, 2021
gileluard added a commit that referenced this issue Sep 20, 2021
@gileluard
[spaces] several fixes for pre release
c1a542e 
- [Space home view inherits title from previously viewed tab](#4851)
- [Home view doesn't refresh when new rooms are created](#4849)
- [Odd error message in Space member list](#4845)
- [Bring leaving space experience in line with Web](#4850)
- [No notification for space invitation](#4840)
- [Remove filter when space is switched](#4852)
- [M10.11 Remove community tab](#4493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kittykat kittykat

@gileluard gileluard

Labels
A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems X-Release-Blocker Z-Spaces-Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kittykat @gileluard