Visual inconsistencies in Settings

[neilalexander]

Steps to reproduce

There are a number of visual inconsistencies in the Settings pane:

1. The text sizes of some labels are larger than others;
2. The padding/alignment of some labels are incorrect (showing further left than others);
3. Some screens (such as Notifications) also have inconsistent text sizes compared to the rest of the settings.

Screenshots:

What happened?

See above.

Your phone model

iPad Pro

Operating system version

iOS 15.0.2

Application version

1.6.5 Testflight 20211014093455

Homeserver

matrix.org

Have you submitted a rageshake?

No

[pixlwave]

Hi @neilalexander, thanks for the report. The alignment issue is already covered in #4799.

The text sizes is very likely that some of the cells/screens are set up for dynamic type, and others aren't. Can you confirm if you have the text size slider reduced in Settings? I think in that case this part of the issue would be adequately covered by #4444.

[neilalexander]

Hey @pixlwave, I do indeed have the text size reduced somewhat in Settings. The problem largely goes away in the top-level of the Settings if I set it back to the middle setting, but the text sizes in "Default Notifications", "Mentions & Keywords" etc are still smaller in all cases.

[pixlwave]

For me those two notifications screens revert back to the correct size if I force quit and open again - it seems our SwiftUI theme is currently only aware of light/dark mode changes and changes to the dynamic type.

[neilalexander]

If I force-quit the app and re-launch, the sizes in the notification screens do update to whatever the Dynamic Type size is now, but that still looks to be smaller than most of the fonts used in the top-level Settings screen, so I guess this will probably not be fully resolved until Dynamic Type is supported app-wide?

[pixlwave]

Yes, looking through the Settings screen, there's even some 1pt inconsistencies in there between the different sizes of some of the cells. When all the fonts are set from our theme, this should ultimately be resolved.

[neilalexander]

OK, if both of the issues outlined in this issue are already being dealt with in other issues/PRs then happy to close as a duplicate, or would you prefer to keep it open?

[pixlwave]

I've opened #5027 for the SwiftUI issue and mentioned this in it for reference (as the screenshots are handy!) so its covered for all 3 areas now 🙂

[neilalexander]

Great, thanks for the fast triage!