Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic Type in SwiftUI #5027

Closed
pixlwave opened this issue Oct 20, 2021 · 0 comments · Fixed by #5646
Closed

Dynamic Type in SwiftUI #5027

pixlwave opened this issue Oct 20, 2021 · 0 comments · Fixed by #5646
Labels
A11y O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@pixlwave
Copy link
Member

pixlwave commented Oct 20, 2021 •
edited
Loading

Our SwiftUI components are technically set up for dynamic type, however the injected theme isn't aware of any changes the user makes from the Settings app. To reproduce:

  • Open the notifications Mentions & Keywords screen from the app settings.
  • Switch to the system Settings app.
  • Change the text size in Display
  • Switch back to Element

The font sizes remain unchanged. However a force quit and relaunch will reveal that the fonts are indeed capable of resizing.

Note: More discussion can be seen in #5026 and related to #4444.
@pixlwave pixlwave added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A11y S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Oct 20, 2021
@pixlwave pixlwave mentioned this issue Oct 20, 2021
Open
@pixlwave pixlwave mentioned this issue Feb 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A11y O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a SharedFont type to ElementFonts. element-hq/element-ios
1 participant
@pixlwave