Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing notification strings don't fall back to en. #5996

Closed
pixlwave opened this issue Apr 6, 2022 · 1 comment
Closed

Missing notification strings don't fall back to en. #5996

pixlwave opened this issue Apr 6, 2022 · 1 comment
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@pixlwave
Copy link
Member

pixlwave commented Apr 6, 2022 •
edited
Loading

This is now very visible for users who are using languages that were enabled in 1.8.11 and don't have complete translations in Localizable.strings.

Steps to reproduce

  1. Change your device language to Finnish
  2. Wait on the device's lock/home screen and receive a notification from a user in a room (not a DM).

Outcome

What did you expect?

To see "{user} in {room}" as the notification's title.

What happened instead?

The notification title shows as "MSG_FROM_USeR_IN_ROOM_TITLE", presumably as the NSE is using NSString.localizedUserNotificationString with no fallback.
IMG_0370

Your phone model

iPhone 12

Operating system version

iOS 15.4.1

Application version

Element 1.8.11 RC

Homeserver

No response

Will you send logs?

No
@pixlwave pixlwave added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Apr 6, 2022
@pixlwave pixlwave added A-Notifications S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience O-Occasional Affects or can be seen by some users regularly or most users rarely and removed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Apr 6, 2022
@pixlwave pixlwave mentioned this issue Apr 6, 2022
Merged
@pixlwave
Copy link
Member Author

pixlwave commented Apr 6, 2022

Closed by #6000

@pixlwave pixlwave closed this as completed Apr 6, 2022
@pixlwave pixlwave mentioned this issue Apr 8, 2022
Merged
@pixlwave pixlwave mentioned this issue Apr 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notifications O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pixlwave