Make sure strings fall back to English if missing in the Notification extension #6000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
requested review from
a team and
gileluard
and removed request for
a team
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/yBuLXE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a long running bug which become more visible following on from #5936. Instead of using
NSString.localizedUserNotificationStringwhich provides no fallback, this PR adds alocalizedString(forKey:_:)method that uses similar logic toVectorL10n, but specifically requests the strings from the main app bundle.In order for this to work, MXKLanguageBundle now always references
Bundle.appinstead ofBundle.mainso thatsetupMXKLanguageBundlewas called on the same bundle that the strings request goes to. I've updatedVectorL10nto do the same thing - this has the happy coincidence of allowing the share extension to show in the system language as well which I don't believe it was doing before 😄Fixes #5996