Add support for sending slow motion videos #4541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slow motion videos are returned as AVComposition objects when picked. which lacks a URL property.
This was referenced Jul 9, 2021
gileluard
approved these changes
Jul 12, 2021
|
Additionally tested pasting a video into the message composer too. |
gileluard
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4483. Slow motion videos are returned from the photos picker as
AVCompositionobjects which weren't handled appearing as though the picker ignored your tap. To fix this, after picking a video it is no longer passed around as a URL to the video, but as theAVAssetoriginally returned fromPHImageManager.I've tested sending regular and slow motion (where possible) videos from these 3 sections of the composer:
as well as from the share extension.
Depends upon: matrix-org/matrix-ios-kit#848 and matrix-org/matrix-ios-sdk#1153.
Note: Some slow motion videos may still ultimately fail to send due to their large file sizes.