Voice message additions #4661
Merged
Voice message additions #4661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k screen or the control center.
… application becomes inactive. Updated changes.rst.
Merged
ismailgulek
reviewed
Aug 5, 2021
| } | ||
|
|
||
| let nowPlayingInfoCenter = MPNowPlayingInfoCenter.default() | ||
| nowPlayingInfoCenter.nowPlayingInfo = [MPMediaItemPropertyTitle: audioPlayer.displayName ?? "Voice message", |
There was a problem hiding this comment.
We could localize "Voice message" string?
…er.swift Co-authored-by: Stefan Ceriu <stefanc@matrix.org>
Fix Room Avatar
ismailgulek
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4655 - Allowing voice message playback to be controlled from the lock screen or the control center.
VoiceMessageMediaServiceProviderso that it keeps working properly if the currently playing voice message (cell) gets scrolled off screen and deallocated.#4656 - Stop recording voice message and go into locked mode when the application becomes inactive.