-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account Notification Settings and Keywords #4752
Account Notification Settings and Keywords #4752
Conversation
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/u72nKV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a Riot/.DS_Store file that's been added. Should probably be removed.
Riot/Modules/Settings/Notifications/Model/NotificationSettingsScreen.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Settings/Notifications/SwiftUI/BorderedInputFieldStyle.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Settings/Notifications/SwiftUI/DefaultNotificationSettings.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Settings/Notifications/SwiftUI/OtherNotificationSettings.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Settings/Notifications/Model/NotificationIndex.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Settings/Notifications/ViewModel/NotificationSettingsService.swift
Outdated
Show resolved
Hide resolved
Riot/Modules/Settings/Notifications/ViewModel/NotificationSettingsViewModelType.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More comments below ⬇️
There are a few more instances of using /*
instead of /**
for doc comments. Related question:
Do we have a convention of whether we use ///
or /** */
in Swift? I've been using the former as Xcode generates it that way with the keyboard shortcut ⌘ ⌥ /
but I think I prefer the multiline style visually.
Whats in this PR
Default Notifications
,Mentions and Keywords
andOther
(as in Figma)Chip
,Chips
,ChipInput
components that render in a flow layout.NotificationSettingsService
andNotificationSettingsViewModel
make use if combine to observe the push rule state ofMxNotificationCenter
. A nice off-shot of this is that the settings and keywords update 'live' to reflect any changes(say made from another client)since opening the screen.swift-collections
to simplify build for the moment.Adds theswift-collections
library for use of theOrderedSet
so that keywords don't jump around and are ordered in a sensible way for the end user.BorderedInputFieldStyle
was added but not used in settings in the end. Keeping implementation though as will probably go into DesignKit.What it loos like
Todos
resolves #4469
resolves #4468
resolves #4467