Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Notification Settings and Keywords #4752

Merged
merged 16 commits into from
Aug 26, 2021

Conversation

langleyd
Copy link
Member

@langleyd langleyd commented Aug 25, 2021

Whats in this PR

  • The ability to enabled/disable notifications across Default Notifications, Mentions and Keywords and Other (as in Figma)
  • Updates the build setting to apply both room + account notifications
  • Defines the 'PushRuleDefinitions' to very closely mirror how they are defined on iOS and Android
  • It adds Chip,Chips, ChipInput components that render in a flow layout.
  • The NotificationSettingsService and NotificationSettingsViewModel make use if combine to observe the push rule state of MxNotificationCenter. A nice off-shot of this is that the settings and keywords update 'live' to reflect any changes(say made from another client)since opening the screen.
  • Removed swift-collections to simplify build for the moment. Adds the swift-collections library for use of the OrderedSet so that keywords don't jump around and are ordered in a sensible way for the end user.
  • BorderedInputFieldStyle was added but not used in settings in the end. Keeping implementation though as will probably go into DesignKit.

What it loos like

AccountNotificationsiOS

Todos

  • Add towncrier
  • Fix chip text colour in dark mode

resolves #4469
resolves #4468
resolves #4467

@github-actions
Copy link

github-actions bot commented Aug 25, 2021

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/u72nKV

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a Riot/.DS_Store file that's been added. Should probably be removed.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments below ⬇️

There are a few more instances of using /* instead of /** for doc comments. Related question:
Do we have a convention of whether we use /// or /** */ in Swift? I've been using the former as Xcode generates it that way with the keyboard shortcut ⌘ ⌥ / but I think I prefer the multiline style visually.

@langleyd langleyd merged commit 45540f1 into develop Aug 26, 2021
@langleyd langleyd deleted the langleyd/4467_account_notification_settings branch August 26, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants