Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add URL previews as a Labs feature #4790
Add URL previews as a Labs feature #4790
Changes from 25 commits
eacb8a4
661b536
22382e9
29758d1
5f598a9
59e5416
a81ebbd
042eb8e
9fb13b7
1831b61
4924110
6a5b12a
2e04123
be83d8e
80f8cc6
7db81cc
434657e
cf3733c
55df930
7448ca1
1c7adf0
0094add
4ad0416
c007bc5
08d548c
1c7cef5
ea14ed9
24afc7a
206017c
2656746
ad618b4
dfb63e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if we will have more Core Data entities which prefix or suffix we can use to distinguish the managed object from the memory object. A convention like
CDURLPreviewData
for Core Data andURLPreviewData
for the memory representation?