Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy Load Room Summaries: Milestone 0 #4907

Merged
merged 46 commits into from
Oct 19, 2021
Merged

Lazy Load Room Summaries: Milestone 0 #4907

merged 46 commits into from
Oct 19, 2021

Conversation

ismailgulek
Copy link
Contributor

@ismailgulek ismailgulek commented Sep 24, 2021 •
edited
Loading

Implements milestone 0 for #4384

@github-actions
Copy link

github-actions bot commented Oct 1, 2021 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HF6aAM

@ismailgulek ismailgulek marked this pull request as ready for review October 5, 2021 10:31
manuroe
manuroe reviewed Oct 6, 2021
View reviewed changes
Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

How can we use MockRecentsListService?

manuroe
manuroe reviewed Oct 11, 2021
View reviewed changes
Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM so far.

@ismailgulek
Copy link
Contributor Author

ismailgulek commented Oct 12, 2021 •
edited
Loading

Awesome work!

How can we use MockRecentsListService?

We can instantiate it like:

id<RecentsListServiceProtocol> recentsListService = [MockRecentsListService generateWithNumberOfRooms:#number_of_rooms];

at https://github.com/vector-im/element-ios/blob/678f7e2e96c1b4e7ef313562d43f1f7715720ec7/Riot/Modules/TabBar/MasterTabBarController.m#L342

Below is for 100000 rooms in total:
Simulator Screen Shot - iPhone 11 Pro - 2021-10-12 at 22 58 58

manuroe
manuroe approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ismailgulek ismailgulek merged commit e57df2f into develop Oct 19, 2021
@ismailgulek ismailgulek deleted the ismail/4384_room_summary_store branch October 19, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuroe manuroe manuroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismailgulek @manuroe