Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split view: Improve detail view management and add possibility to stack views on it #4960

Merged
merged 59 commits into from
Oct 11, 2021

Conversation

SBiOSoftWhare
Copy link
Contributor

@SBiOSoftWhare SBiOSoftWhare commented Oct 6, 2021

Part of #4821 and #4734

… pop completion and replacing detail controller.
… a UINavigationController controller instance.
… Conform to MasterTabBarControllerDelegate updates. Conform to SplitViewMasterPresentable updates.
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/YF2Xrb

SBiOSoftWhare and others added 23 commits October 8, 2021 11:45
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
…Coordinator.swift

Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggestions added, otherwise looks great!

I just gave it a quick go and noticed that an issue similar to #4524 appears to be occurring again with the changes though 😕

Riot/Modules/TabBar/TabBarCoordinator.swift Outdated Show resolved Hide resolved
SBiOSoftWhare and others added 3 commits October 11, 2021 11:10
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SBiOSoftWhare SBiOSoftWhare merged commit f891cce into develop Oct 11, 2021
@SBiOSoftWhare SBiOSoftWhare deleted the steve/4734_master_tab_bar_refacto branch October 11, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants