Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spaces] M10.4.1 Home space data filtering #4570 #4965

Merged
merged 8 commits into from
Oct 18, 2021
Merged

[Spaces] M10.4.1 Home space data filtering #4570 #4965

merged 8 commits into from
Oct 18, 2021

Conversation

gileluard
Copy link
Contributor

@gileluard gileluard commented Oct 7, 2021 •
edited
Loading

fix #4886, fix #4570

testable build: https://i.diawi.com/p2DowK

ezgif-3-9fce520775d8
Simulator Screen Shot - iPhone 12 Pro - 2021-10-07 at 15 41 40

@github-actions
Copy link

github-actions bot commented Oct 7, 2021 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/pATcL3

niquewoodhouse
niquewoodhouse reviewed Oct 7, 2021
View reviewed changes
Copy link

@niquewoodhouse niquewoodhouse left a comment •
edited by gileluard
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Getting different visual feedback with this switch, than other switches:
delight-home-01.mov
delight-settings-01.mov

I think it would be good if they felt the same.

@kittykat kittykat mentioned this pull request Oct 7, 2021
Closed
@gileluard
Copy link
Contributor Author

@niquewoodhouse here is a new build for you https://i.diawi.com/SagcTK
SagcTK

pixlwave
pixlwave reviewed Oct 15, 2021
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments line.

Riot/Modules/Spaces/SpaceMenu/SpaceMenuCell.swift Outdated Show resolved Hide resolved
Riot/Modules/Spaces/SpaceMenu/SpaceMenuListItemViewData.swift Show resolved Hide resolved
Riot/Modules/Spaces/SpaceMenu/SpaceMenuListItemViewData.swift Outdated Show resolved Hide resolved
Riot/Modules/Spaces/SpaceMenu/SpaceMenuSwitchViewCell.swift Show resolved Hide resolved
@gileluard gileluard merged commit d3413a7 into develop Oct 18, 2021
@gileluard gileluard deleted the gil/4570_home_space_data_filtering branch October 18, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niquewoodhouse niquewoodhouse niquewoodhouse approved these changes

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Private space invite should use lock icon instead of planet [Spaces] M10.4.1 Home space data filtering
3 participants
@gileluard @niquewoodhouse @pixlwave