Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table view headers and footers in Settings. #5011

Merged
merged 8 commits into from
Oct 21, 2021
Merged

Table view headers and footers in Settings. #5011

merged 8 commits into from
Oct 21, 2021

Commits on Oct 20, 2021

  1. Use headerTextPrimaryColor in headers and don't override system font … 

    …size.
    @pixlwave
    pixlwave committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    8e8efd4 View commit details
    Browse the repository at this point in the history

  2. Use footnote text style for description cells to match UITableView's … 

    …footer style. Match the footer colour to the header colour. Add -[SettingsViewController descriptionCellForTableView:] and use for appropriate cells.
    @pixlwave
    pixlwave committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    80e6e4a View commit details
    Browse the repository at this point in the history

  3. Use actual footer titles rather than cells that mimic them.

    @pixlwave
    pixlwave committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    685d8f2 View commit details
    Browse the repository at this point in the history

  4. Update fonts, add attributed strings and add tap gestures back. 

    Footers use subheadline. Headers use footnote.
    @pixlwave
    pixlwave committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    4b5630a View commit details
    Browse the repository at this point in the history

  5. Use footers for app and discovery information. 

    Remove Invite Friends button from settings.
Reorganise Advanced and Other settings.
Rename Other to About.
    @pixlwave
    pixlwave committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    7a096a7 View commit details
    Browse the repository at this point in the history

  6. Fix bug accepting identity server terms from the Setting Discovery se… 

    …ction.
    @pixlwave
    pixlwave committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    2f879e8 View commit details
    Browse the repository at this point in the history

  7. Add SectionFooterView.xib to fix fonts on iOS 12-14. 

    Update SecurityViewController too.
    @pixlwave
    pixlwave committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    614cb4d View commit details
    Browse the repository at this point in the history

  8. Address Steve's comments.

    @pixlwave
    pixlwave committed Oct 20, 2021
    Configuration menu
    Copy the full SHA
    a7395db View commit details
    Browse the repository at this point in the history