Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrency to GitHub workflows to auto-cancel older runs. #5101

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Nov 5, 2021

This limits GitHub actions to only allow each workflow to have a single concurrent run per branch. The result is that pushing new changes to a PR will automatically cancel older runs, freeing up more CI instances for us to use.

Caveat: The same effect will happen on develop too, so if 2 PRs are merged within a short time of each other, only the newer one would have CI results. I'm not sure if this is desirable behaviour or not?

@github-actions
Copy link

github-actions bot commented Nov 5, 2021

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/dMGRi3

@SBiOSoftWhare SBiOSoftWhare self-requested a review November 5, 2021 15:56
@SBiOSoftWhare
Copy link
Contributor

Caveat: The same effect will happen on develop too, so if 2 PRs are merged within a short time of each other, only the newer one would have CI results. I'm not sure if this is desirable behaviour or not?

Yes on develop it will be safer to check each PR

@pixlwave
Copy link
Member Author

pixlwave commented Nov 5, 2021

Yes on develop it will be safer to check each PR

Updated using this technique: https://stackoverflow.com/a/68422069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants