Space creation element-ios #5182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Initial space creation flow
- Reverted LegacyAppDelegate
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/C2LD4K |
niquewoodhouse
suggested changes
Nov 29, 2021
There was a problem hiding this comment.
I tried to be clear below but please let me know if it's not. Overall, looking really good I think.
Sidebar
- Change copy from "add space" to "create space" (you can only create)
- Remove help from links (site doesn't work, so its an unhelpful distraction)
- In dark theme, plus icon should be white to match initials on avatars
Form header
- Icons for back and cancel are different sizes, can they be the same? Let me know if new icons are required.
- The back icon should bring up a confirm alert, like this
- Just as an idea for another build, could we try what it's like without the title in the middle of the header? I'm wondering if it's not helpful because it distracts from the content (see below image - so removing the title in the headers once you've decided which space type you'll start with).
Create space - pick space type
- Change copy on buttons "Private" instead of "Private space" and "Public" instead of "Public space"
- Icons in buttons look blurry - let me know if they need altering or optimising in someway
- I think changing the buttons slightly will make them stand out a bit better, like this
- Increase size of 'you can change this later' to footnote.
Naming space step
- Can the name be on focus when you arrive at this step?
- Can the intro copy be included in the scrolling area (like below)
ele-ios-spaces-space-details01.mp4
- There's a big gap between the avatar section and the name - so they don't feel part connected
- Topic should be called description
- When the topic is on focus, the down arrow (bottom right of the field) feels strange for iOS and looks like a download option
- Name error message "Name the room" isn't appropriate, if it needs to be generic "Name required" would suffice
- In dark theme, text in avatar should be white to match final avatar (always white text)
- Position of the circle behind the camera icon and the icon itself don't feel quite right (design below)
Private space - decide access step
- Change copy "Make sure the right people have access
to." - Change size of "you can change this later" to match earlier change in space type change
- Change design of buttons to match space type change
Create rooms step
- Can the copy and the fields be part of the same scrolling experience as shown on other steps
- More margin between each room input, please - margins in first step feel good
Private space - just me - pick rooms
- The interaction of selecting a room seems to fade in/out the selected room. Can it remain onscreen and just the checkbox changes?
- The scroll area should include everything
- Search hint could just be search
- I'd like to change from showing room id (which doesn't seem very helpful) to showing the Space it's in (if in a space), Space name + X others (if in multiple spaces) and nothing if not in any space (see video)
ele-ios-spaces-just-me-add-rooms01.mp4
Creating space loading
- Wondering if changing the big spinner for the space avatar might help
- Change copy to remove space and room, so it says Creating Runners world, instead of Creating space Runners world.
- When you make the space, it would be nice to be dropped into the space home tab I think, without the sidebar expanded.
Discussion points
- The input fields generally look shorter than intended, which makes the form feel a bit claustrophobic, and makes the giant Next buttons stick out more than necessary.
niquewoodhouse
suggested changes
Dec 1, 2021
There was a problem hiding this comment.
Exit
- Change copy to this
Flow step 1 - pick space type
-
Not importantThere's a strange animation when you try to swipe down to dismiss
RPReplay_Final1638370029.MP4
Buttons and icons are looking much better, thanks!
Flow step 2 - space details
- There's too much of a gap between the avatar and form and intro copy, and the keyboard has an empty suggested text which means you can't really see what's happening. I'm very open to altering the design and content to accommodate things but I think it's important it opens with the name on focus.
RPReplay_Final1638371772.MP4
Flow step 4 - just me - add existing rooms
- Sometimes, the options don't feel like they respond. I tap an existing room several times and it might not change to being selected.
Header
- Wonder if we can move the icons up a tiny bit or make the header shorter? At the moment they're not vertically centered to the header
- Update after design review
- Update after design review
- Update after design review
- Updated swiftui tests
- Consolidated current flow
- UI tweaks in space settings screen
- UI tweaks in space settings screen
gileluard
changed the title
niquewoodhouse
suggested changes
Dec 16, 2021
There was a problem hiding this comment.
@gileluard after our earlier chat, ere are my other notes:
Loading screen
- Change 'done' to 'cancel' or 'exit' because it cancels the space creation?
- UI tweaks in space settings screen
# Conflicts: # Common/Mock/MockAppScreens.swift
- added changelog + additional tweaks
manuroe
reviewed
Jan 4, 2022
...SpaceCreationMatrixItemChooser/Service/MatrixSDK/SpaceCreationMatrixItemChooserService.swift
Outdated
Show resolved
Hide resolved
...SpaceCreationMatrixItemChooser/Service/MatrixSDK/SpaceCreationMatrixItemChooserService.swift
Outdated
Show resolved
Hide resolved
...aceCreation/SpaceCreationPostProcess/Service/MatrixSDK/SpaceCreationPostProcessService.swift
Outdated
Show resolved
Hide resolved
...aceCreation/SpaceCreationPostProcess/Service/MatrixSDK/SpaceCreationPostProcessService.swift
Outdated
Show resolved
Hide resolved
RiotSwiftUI/Modules/Spaces/SpaceCreation/SpaceCreationRooms/View/SpaceCreationRooms.swift
Show resolved
Hide resolved
# Conflicts: # Riot/Generated/Strings.swift # Riot/Assets/en.lproj/Vector.strings
…emChooser/Service/MatrixSDK/SpaceCreationMatrixItemChooserService.swift Co-authored-by: manuroe <manuroe@users.noreply.github.com>
…ess/Service/MatrixSDK/SpaceCreationPostProcessService.swift Co-authored-by: manuroe <manuroe@users.noreply.github.com>
- Update after code review
…ement-ios into gil/143_create_public_space
# Conflicts: # RiotSwiftUI/Modules/Common/Mock/MockAppScreens.swift
- Update after code review
manuroe
approved these changes
Jan 26, 2022
There was a problem hiding this comment.
Thanks @gileluard and @niquewoodhouse for having taken into account my remarks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://github.com/vector-im/internal-planning/issues/143
fix #5224
Internal build here: https://i.diawi.com/MPjVq8
Description of the flow
Files
Create spaceoption in side menu3.1. FLow coordinator
3.2. Menu screen for scpace creation (e.g. space type selection screen and space private visibility selection screen)
3.3. space settings screen (e.g. name, topic, alias, and avatar)
3.4. Room creation screen
3.5. Matrix Item selection (e.g. room selection screen and invite user selection screen). Note that
SpaceCreationMatrixItemChooserhas been refactored and generalised in another PR to be reused for other purposes3.6. Email invites screen
3.7. Post process screen: basically calls SDK to perform requested actions according user preferences