Fix bugs when building with Xcode 13.

[pixlwave]

Fixes #4883.

• Navigation bars are assigned a bar appearance for both standard and scroll edges.
  Fixes Navigation bars appear transparent on some modal screens. #4884
• Table view header padding is set to 0.
  Fixes Extra spacing is inserted before the headers in HomeViewController. #4941
• Home space icon would update with incorrect content mode.
  Fixes Sometimes space icons are zoomed in #5177
• Adopt the new tab bar style when scrolled to the bottom of a list.
• Fix room list jumping when long pressing a room on the Home tab by using the standard context menu on iOS 13+.
• Update Fastfile for CI

A couple of notes on the context menu:

• I've used SF Symbols as the outlined style is more familiar in UIKit's context menus, however some shapes are inconsistent with our other images 😕
• It is only added on the Home tab in this PR, but Favourites / People / Rooms could be updated if desired.
• The menu items are labeled are as follows:

Enable	Disable
Direct Chat	Room
Mute or Notifications**	Un-mute or Notifications**
Favourite	Un-favourite
Low Priority	Normal Priority
Leave

** Notifications is shown by default and presents the notifications settings screen. Some forks may have this disabled and those will show Mute/Un-mute instead

Last Steps:

• Add localisations for the strings

Tab bar (without content underneath)	Context menu

A low priority muted room	A favourited DM with notifications	A low priority DM

[github-actions]

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/Knqizo

[pixlwave]

@daniellekirkwood / @amshakal Could you take a look at the changes to the context menu on this PR please? I've done what makes sense to me but I think the "Direct Chat/Room" string is probably no clearer than the icon was on its own and the changes to the icons clearly need reviewing.

[daniellekirkwood]

I'm comfortable with the change to the context menu on the Home screen, and the icons (as they're similar enough to communicate the same thing but also recognisable Apple icons).

What I'd like to discuss further is the content in this menu... My suggestion would be:

Current copy	Suggested copy
Direct chat/ Room	Move to People / Move to Rooms
Mute/Unmute or Notifications	Mute/ Unmute or Notifications
Favourite/Un-favourite	Favourite / Remove from Favourites
Low priority/Normal priority	Low priority / Normal priority
Leave	Leave

[ShadowJonathan]

Mute/ Unmute or Notifications

(this seems to be missing a space before the /?)

[daniellekirkwood]

Mute/ Unmute or Notifications

(this seems to be missing a space before the /?)

The copy would either be Mute or Unmute dependant on the current setting the user has

[pixlwave]

@daniellekirkwood In terms of string length, screenshots below with the longest string on the smallest phone.

iPhone SE	iPhone SE w/ larger font

[pixlwave]

One last comment on the symbols, the one for leave isn't supported on iOS 13, so it is currently using xmark instead.

[daniellekirkwood]

Looks good to me. Will need @amshakal 's review on Monday

[stefanceriu]

Would like to make the context menu preview provider a bit more generic, otherwise looks good to me 👍

[stefanceriu]

👏

[amshakal]

Hello, just a few comments:

1. Agree with all copy changes suggested above besides 'remove from favourites'. Can we stick to un-favourite? I think the long string length makes it less scalable.
2. I think x mark is fine for now, I am sure we'll be able to update the icon later on. Do we have options that we can choose from?

Thank you!

[daniellekirkwood]

1. Agree with all copy changes suggested above besides 'remove from favourites'. Can we stick to un-favourite? I think the long string length makes it less scalable.

Not sure how easy "un-favourite" is to translate so we might have to show 'un-favourite' in english and provide the "remove from favourites" string for other regions to translate?

I'd rather us go with "Remove from Favourites" but happy to roll with @amshakal's suggestion.

[pixlwave]

Do we have options that we can choose from?

These are all from the SF Symbols library. If you don't have it, you can install the symbol browser from here: https://developer.apple.com/sf-symbols/

You can check what will work on iOS 13 by looking for an availability of 1.0 in sidebar.

[amshakal]

• Okay, that's complicated. We can stick to 'Remove from Favourites', just really wish it could be shortened.

• As for symbols, seems like sticking with x makes sense for now.