Add support for UserProperties to analytics and capture FTUE use case selection. #5591
Conversation
… selection. Additionally update taps to interactions following updates in the analytics event repo.
| /// - Parameter session: The session to gather any user properties from. | ||
| /// - Returns: The properties to be set. | ||
| private func makeUserProperties(for session: MXSession) -> AnalyticsEvent.UserProperties { | ||
| var useCaseSelection: AnalyticsEvent.UserProperties.FtueUseCaseSelection? |
There was a problem hiding this comment.
It took me a while to understand what useCase means in this context. It seems we use it both for architectural components (e.g. OnboardingUseCase) as well as a specific feature (i.e. use case = reason to use element). Is this correct?
There was a problem hiding this comment.
Ohhhh, thanks for pointing this out. I meant to rename OnboardingUseCase to OnboardingUseCaseScreen/OnboardingUseCasePicker/OnboardingUseCaseView after I created it. That's the screen where the useCase is selected.
It's annoying that the analytics schema has this as UseCaseSelection and not just UseCase. Do you think it would be clearer rename all occurrences of useCase to useCaseSelection for consistency?
There was a problem hiding this comment.
I think my confusion was broader, as the term "use case" itself (even as "use case selection"), refers to something quite generic wherease the FTUE means a more specific meaning, something like "what is your reason to use element". So to push it to an extreme, this would be FTUEUseCaseUseCase 😅 . Obviously I'm not suggesting we use that name, I was just trying to understand that distinction.
There was a problem hiding this comment.
For instance looking at this type UserSessionProperties.UseCase on its own, I would not know what it refers to without a wider context
There was a problem hiding this comment.
Understood, I'll have a think about this (Definition 2 in that link seems entirely new to me), but will go ahead and merge this PR 👍
Same for OnboardingUseCaseCoordinator.
Additionally update taps to interactions following updates in the analytics event repo.
Post review steps
release/swiftin the Analytics repopod update AnalyticsEventsFixes #5590.