Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable home activity indicator #5665

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Enable home activity indicator #5665

merged 2 commits into from
Feb 25, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Feb 22, 2022

Resolves #5663

iPhone 8 portrait iPhone 8 landscape
Simulator Screen Shot - iPhone 8 - 2022-02-22 at 11 49 10 Simulator Screen Shot - iPhone 8 - 2022-02-22 at 11 49 12
iPhone 13 dark 1 iPhone 13 dark 2
Simulator Screen Shot - iPhone 13 - 2022-02-22 at 11 51 03 Simulator Screen Shot - iPhone 13 - 2022-02-22 at 11 51 06
iPhone 13 landscape dark 1 iPhone 13 landscape dark 2
Simulator Screen Shot - iPhone 13 - 2022-02-22 at 11 51 10 Simulator Screen Shot - iPhone 13 - 2022-02-22 at 11 51 12
iPad portrait iPad landscape
Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-02-22 at 11 54 45 Simulator Screen Shot - iPad Pro (12 9-inch) (5th generation) - 2022-02-22 at 11 54 47

@Anderas
Copy link
Contributor Author

Anderas commented Feb 22, 2022

@amshakal similar to #5603, the dark mode might need some extra love, especially when the filter field is directly underneath it

@github-actions
Copy link

github-actions bot commented Feb 22, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/LrhLkd

@Anderas Anderas mentioned this pull request Feb 23, 2022
Closed
@Anderas
Copy link
Contributor Author

Anderas commented Feb 23, 2022

Light Dark
Simulator Screen Shot - iPhone 13 - 2022-02-23 at 09 16 23 Simulator Screen Shot - iPhone 13 - 2022-02-23 at 09 16 14

This was referenced Feb 24, 2022
Merged
Closed
Closed
@Anderas Anderas merged commit bcbc97d into develop Feb 25, 2022
@Anderas Anderas deleted the andy/5663_enable_indicator branch February 25, 2022 10:46
@amshakal
Copy link

TY!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismailgulek ismailgulek ismailgulek approved these changes

@amshakal amshakal Awaiting requested review from amshakal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable new activity indicator on home screen
3 participants
@Anderas @amshakal @ismailgulek