Use only latest profiles in the room timeline (labs) #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aringenbach
added
T-Enhancement
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/aNhBGq |
aringenbach
removed
T-Enhancement
langleyd
requested changes
Mar 4, 2022
There was a problem hiding this comment.
Overall code looks great! Just a few comments around naming.
Most importantly I think we should make the user description of the flag a bit more explicit(and consistent with web/android) and the BuildSetting also so that it's clear for downstream forks.
To a lesser extent I think it could also make things a little bit clearer for engineers to read.
stefanceriu
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5726
Note: Enabling or disabling this setting will require a clear cache in order to be immediately effective (otherwise it will only apply for new events or after someone updates their profile in
enabledcase).