Reduce the number of unnecessary home page reloads #5969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team and
gileluard
and removed request for
a team
Anderas
force-pushed
the
andy/5619_home_reloads
branch
from
4f26993
to
08b48b6
Compare
Anderas
commented
Apr 4, 2022
| } | ||
| multicastDelegate.invoke { $0.recentsListServiceDidChangeData?(self, |
There was a problem hiding this comment.
Seems like we have been doing 2 updates when only one was necessary
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/EKH8Az |
gileluard
approved these changes
Apr 4, 2022
| } | ||
| } else { |
There was a problem hiding this comment.
Suggested change
| } else { | |
| } | |
| else | |
| { |
| } | ||
| } else if (!changes) { |
There was a problem hiding this comment.
Suggested change
| } else if (!changes) { | |
| } | |
| else if (!changes) | |
| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5619
After a refactor where home sections are represented as enum values it is now easier to compare the changes coming from list sources and more accurately determine whether to reload the entire table view (when sections have changed) versus when to only update individual sections.
Overal this change should lead to fewer unnecessary reloads of the entire home screen.