Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings. #6032

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Fix some warnings. #6032

merged 1 commit into from
Apr 13, 2022

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Apr 13, 2022

The parameter warnings were being repeated. This PR (along with one in the SDK) takes the warning count from ~750 down to ~275.

@pixlwave pixlwave requested review from a team, yostyle and aringenbach and removed request for a team and yostyle April 13, 2022 09:09
@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/dkNA3Y

Copy link
Contributor

@aringenbach aringenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pixlwave pixlwave merged commit c04db50 into develop Apr 13, 2022
@pixlwave pixlwave deleted the doug/fix_warnings branch April 13, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants