Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4850 bring leaving space experience in line with web #6062

Merged

Conversation

gileluard
Copy link
Contributor

resolves #4850

ezgif-4-5fffe2e18c

…n_line_with_Web

# Conflicts:
#	Riot/Modules/Spaces/SpaceRoomList/SpaceChildRoomDetail/SpaceChildRoomDetailViewModel.swift
…n_line_with_Web

# Conflicts:
#	Riot/Generated/UntranslatedStrings.swift
…n_line_with_Web

# Conflicts:
#	RiotSwiftUI/Modules/Spaces/MatrixItemChooser/MockMatrixItemChooserScreenState.swift
- Hide selection bar when filtering room list
@gileluard gileluard requested review from a team and SBiOSoftWhare and removed request for a team April 22, 2022 13:22
@github-actions
Copy link

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/grGtmG

@@ -96,6 +99,29 @@ class SpaceMenuPresenter: NSObject {
self.presentingViewController?.present(viewController, animated: animated, completion: nil)
}
}

@available(iOS 14.0, *)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now get rid off these conditions :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right :) I'll do it next time !

@gileluard gileluard merged commit 1a3effb into develop Apr 27, 2022
@gileluard gileluard deleted the gil/4850-Bring_leaving_space_experience_in_line_with_Web branch April 27, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bring leaving space experience in line with Web
2 participants