Location sharing: Integrate live location viewer screen with room screen #6114
Conversation
…entation request.
SBiOSoftWhare
requested review from
a team,
pixlwave and
gileluard
and removed request for
a team
There was a problem hiding this comment.
I've added some comments line line. One more global thought I had was as follows:
I struggled in places to understand names such as stopUserLiveLocationSharing, didUpdateUsersLiveLocation and usersLiveLocation as to whether these are about the current user's location or the location of lots of users. Would be great to have more documentation about these to help explain, or possibly using alternative names along the lines of currentUserLiveLocation/myLiveLocation for the current user and allLiveLocations/roomMemberLiveLocations for other users in the room.
...odules/Room/LiveLocationSharingViewer/Service/LiveLocationSharingViewerServiceProtocol.swift
Outdated
Show resolved
Hide resolved
...ules/Room/LiveLocationSharingViewer/Service/MatrixSDK/LiveLocationSharingViewerService.swift
Show resolved
Hide resolved
|
|
||
| let errorHandler: (Error) -> Void = { error in | ||
|
|
||
| let viewController = self.roomViewController |
There was a problem hiding this comment.
I'm not sure if this local copy adds much to the implementation here?
...odules/Room/LiveLocationSharingViewer/Service/LiveLocationSharingViewerServiceProtocol.swift
Show resolved
Hide resolved
RiotSwiftUI/Modules/Room/LiveLocationSharingViewer/LiveLocationSharingViewerViewModel.swift
Show resolved
Hide resolved
…eLocationSharingViewerServiceProtocol.swift Co-authored-by: Doug <6060466+pixlwave@users.noreply.github.com>
|
📱 Scan the QR code below to install the build for this PR. If you can't scan the QR code you can install the build via this link: https://i.diawi.com/74m9k3 |
#6081