Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence warnings from 3rd-party CocoaPods dependencies #6196

Merged
merged 5 commits into from
Jun 1, 2022
Merged

Silence warnings from 3rd-party CocoaPods dependencies #6196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a678ba
Prevent warnings from 3rd-party code to show up in Xcode
wtimme May 23, 2022
a7d55a0
Remove redundant "inhibit warnings" direction
wtimme May 23, 2022
d039561
Add changelog entry for #6196
wtimme May 25, 2022
95387a6
Let warnings from MatrixSDK and AnalyticsEvents show up in Xcode
wtimme May 31, 2022
a825a5a
Merge remote-tracking branch 'origin/develop' into feature/No-Ticket-…
wtimme May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ source 'https://cdn.cocoapods.org/'
# Uncomment this line to define a global platform for your project
platform :ios, '14.0'

# By default, ignore all warnings from any pod
inhibit_all_warnings!

# Use frameworks to allow usage of pods written in Swift
use_frameworks!

Expand Down Expand Up @@ -42,8 +45,8 @@ end

# Method to import the MatrixSDK
def import_MatrixSDK
pod 'MatrixSDK', $matrixSDKVersionSpec
pod 'MatrixSDK/JingleCallStack', $matrixSDKVersionSpec
pod 'MatrixSDK', $matrixSDKVersionSpec, :inhibit_warnings => false
pod 'MatrixSDK/JingleCallStack', $matrixSDKVersionSpec, :inhibit_warnings => false
end

########################################
Expand All @@ -69,12 +72,11 @@ abstract_target 'RiotPods' do

# PostHog for analytics
pod 'PostHog', '~> 1.4.4'
pod 'AnalyticsEvents', :git => 'https://github.com/matrix-org/matrix-analytics-events.git', :branch => 'release/swift'
pod 'AnalyticsEvents', :git => 'https://github.com/matrix-org/matrix-analytics-events.git', :branch => 'release/swift', :inhibit_warnings => false
# pod 'AnalyticsEvents', :path => '../matrix-analytics-events/AnalyticsEvents.podspec'

# Remove warnings from "bad" pods
pod 'OLMKit', :inhibit_warnings => true
pod 'zxcvbn-ios', :inhibit_warnings => true
pod 'OLMKit'
pod 'zxcvbn-ios'

# Tools
pod 'SwiftGen', '~> 6.3'
Expand Down
4 changes: 2 additions & 2 deletions Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,6 @@ SPEC CHECKSUMS:
zxcvbn-ios: fef98b7c80f1512ff0eec47ac1fa399fc00f7e3c
ZXingObjC: fdbb269f25dd2032da343e06f10224d62f537bdb

PODFILE CHECKSUM: 525efbc379e42474c461991425266c166593d69f
PODFILE CHECKSUM: 37d7f07953015898ac6f2e628e9b20c2bdd55753

COCOAPODS: 1.11.2
COCOAPODS: 1.11.3
1 change: 1 addition & 0 deletions changelog.d/pr-6196.build
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Ensure that warnings from CocoaPods dependencies do not show up in Xcode