Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show fallback when unsupported stages are mandatory #6210

Merged
merged 6 commits into from
May 31, 2022
Merged

Show fallback when unsupported stages are mandatory #6210

merged 6 commits into from
May 31, 2022

Conversation

ismailgulek
Copy link
Contributor

Fixes #6176

@ismailgulek ismailgulek requested a review from pixlwave May 27, 2022 14:55
@github-actions
Copy link

github-actions bot commented May 27, 2022 •
edited
Loading

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ruAKk7

pixlwave
pixlwave reviewed May 30, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, although now I've ready through it, I think I maybe jumped the gun in suggesting when we should first show the fallback. I've added comments inline.

Riot/Modules/Onboarding/AuthenticationCoordinator.swift Show resolved Hide resolved
Riot/Modules/Onboarding/AuthenticationCoordinator.swift Outdated Show resolved Hide resolved
Riot/Modules/Onboarding/AuthenticationCoordinator.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/Common/Service/MatrixSDK/AuthenticationService.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/Login/Coordinator/AuthenticationLoginCoordinator.swift Outdated Show resolved Hide resolved
RiotSwiftUI/Modules/Authentication/Common/Service/MatrixSDK/AuthenticationState.swift Outdated Show resolved Hide resolved
Riot/Modules/Onboarding/AuthenticationCoordinator.swift Outdated Show resolved Hide resolved
@ismailgulek ismailgulek requested a review from pixlwave May 30, 2022 16:56
pixlwave
pixlwave approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the extra changes 🙏

Riot/Modules/Onboarding/AuthenticationCoordinator.swift Outdated Show resolved Hide resolved
Base automatically changed from doug/5151_sso_login to develop May 31, 2022 16:05
@ismailgulek ismailgulek merged commit a9886e4 into develop May 31, 2022
@ismailgulek ismailgulek deleted the ismail/6176_auth_fallback branch May 31, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Authentication: Show Fallback when unsupported stages are mandatory.
2 participants
@ismailgulek @pixlwave