Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix threads out of labs notice HTML formatting #6284

Merged

Conversation

aringenbach
Copy link
Contributor

@aringenbach aringenbach commented Jun 14, 2022

Fixes #6283

Will be based on develop once #6261 is merged

Before After
image image

@aringenbach aringenbach requested review from a team, stefanceriu and ismailgulek and removed request for a team June 14, 2022 08:41
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Riot/Categories/UILabel.swift Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 14, 2022

📱 Scan the QR code below to install the build for this PR.
🔒 This build is for internal testing purpose. Only devices listed in the ad-hoc provisioning profile can install Element Alpha.

QR code

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/jj64Yn

Copy link
Contributor

@ismailgulek ismailgulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an inline comment, otherwise LGTM!

Riot/Categories/UILabel.swift Outdated Show resolved Hide resolved
Riot/Categories/UILabel.swift Show resolved Hide resolved
Base automatically changed from aringenbach/improve_html_formatter to develop June 16, 2022 07:07
@aringenbach aringenbach force-pushed the aringenbach/6283_fix_threads_notice_html_formatting branch from f88402f to 29ca065 Compare June 16, 2022 07:39
@aringenbach aringenbach merged commit f249a04 into develop Jun 16, 2022
@aringenbach aringenbach deleted the aringenbach/6283_fix_threads_notice_html_formatting branch June 16, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some characters aren't rendered properly on Threads HTML notice
3 participants